search

sabre-io / dav

sabre/dav is a CalDAV, CardDAV and WebDAV framework for PHP
http://sabre.io
BSD 3-Clause "New" or "Revised" License
1.54k stars 347 forks source link

DAV\PropPatch::handleRemaining should only register one callback #1553

Open paulmhh opened 4 months ago

paulmhh commented 4 months ago

currently handleRemaining() will create one callback for each remaining property update but with the whole array of remaining properties as parameter. Thus doCallBackMultiProp() is being used (in each callback! It should be either one callback with an array as parameter, or it should multiple callbacks with a string as parameter)

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.24%. Comparing base (c327c0f) to head (937322c). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1553 +/- ## ========================================= Coverage 97.24% 97.24% Complexity 2834 2834 ========================================= Files 175 175 Lines 8843 8843 ========================================= Hits 8599 8599 Misses 244 244 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

paulmhh commented 2 months ago

sorry for the force pushes, had some trouble to run the github workflow and then the cs-fixer wanted some minor change and I had to iterate.

I did test the test without my fix. It fails. With the fix applied it is green.