Make reader more forgiving

sabre-io / dav

sabre/dav is a CalDAV, CardDAV and WebDAV framework for PHP

http://sabre.io

BSD 3-Clause "New" or "Revised" License

1.53k stars 346 forks source link

Make reader more forgiving #156

Closed evert closed 12 years ago

evert commented 12 years ago

Original author: mscher...@gmail.com (June 04, 2012 11:37:31)

When the reader reads this file it will fail because it's not properly formatted. It would be nice if it could only warn about that and jut continue importing:

BEGIN:VCALENDAR PRODID:-//HTC Corporation//Email 1.0 MIMEDIR//EN VERSION:2.0 METHOD:REQUEST BEGIN:VEVENT ATTENDEE;CN=egil@example.net;ROLE=REQ-PARTICIPANT;RSVP=TRUE:MAILTO:egil@example.net DTSTART:20120528T100000Z DTEND:20120528T110000Z DTSTAMP:20120527T164100Z LOCATION: SUMMARY:Trst DESCRIPTION:Assistent: egil@example.com Starttid: 2012-05-28 12:00, sentraleuropeisk normaltid Sluttid: 2012-05-28 13:00, sentraleuropeisk normaltid

~~~~~~~~~

Test

Sendt fra min HTC CLASS:PUBLIC TRANSP:OPAQUE SEQUENCE:0 PRIORITY:5 UID:cdb3cf4b-00ca-4a0c-82bf-a8312a0962f1 X-MICROSOFT-CDO-ALLDAYEVENT:false X-MICROSOFT-CDO-IMPORTANCE:1 END:VEVENT END:VCALENDAR

Original issue: http://code.google.com/p/sabredav/issues/detail?id=218

evert commented 12 years ago

From evert...@gmail.com on June 04, 2012 11:54:13: That's a pretty badly formatted file! I'm not fully sure if it makes sense to hack this in such a way to make this work.

Is this the actual source file?

evert commented 12 years ago

From mscher...@gmail.com on June 06, 2012 14:05:31: Most system ignore the description in this file.

Perhaps you can ignore lines that don't follow specs?

Just to be forgiving of other people's mistakes!

evert commented 12 years ago

From evert...@gmail.com on June 09, 2012 16:12:56: How are you importing this event? If I would add an option setting to the reader, would that solve your usecase?

evert commented 12 years ago

From mscher...@gmail.com on June 11, 2012 06:20:38: This event arrives by e-mail in our groupware application. Then I can accept or decline the event and schedule it in the calendar.

So I use your vobject library not just for caldav but also for importing and scheduling ;)

An option for the reader to disable strict checking would be great! That would solve it.

evert commented 12 years ago

From mscher...@intermesh.nl on June 14, 2012 07:11:10: Sorry for nagging, but will you implement it?

evert commented 12 years ago

From evert...@gmail.com on June 14, 2012 10:02:53: Yes, sounds reasonable. Not sure exactly when though

evert commented 12 years ago

From evert...@gmail.com on September 16, 2012 19:16:25: Fixed here:

https://github.com/evert/sabre-vobject/commit/22a06b0c86b67df1bd5d518cc3d25b538651c528