search

sabre-io / dav

sabre/dav is a CalDAV, CardDAV and WebDAV framework for PHP
http://sabre.io
BSD 3-Clause "New" or "Revised" License
1.49k stars 343 forks source link

Don't break lines between \ and n #190

Closed evert closed 11 years ago

evert commented 11 years ago

Original author: lars.kne...@gmail.com (September 10, 2011 20:47:31)

Because the line break is always after 75 chars, it can happen that a '\n' gets split in 2 pieces.

This breaks at least with Sogo Thunderbird connector.

Have a look at following line:

NOTE:Hallo Lars!\n\nWie geht es dir Heute? Lass uns um 13:30 Uhr treffen.\ n\nBis dann!\n\nLars\n

Character 75 is the \ and character 76 is the n.

I don't know if this is a problem for other clients too, but it should be easy to split the lines only before/after a complete escaped character.

Original issue: http://code.google.com/p/sabredav/issues/detail?id=146

evert commented 11 years ago

From lars.kne...@gmail.com on September 10, 2011 20:51:47: I just checked how Sogo connector sends back this line and the connector also breaks between the \ and n.

At least the connector can eat his own dog food! :-)

Maybe you can check how other client behave. If this is only a Sogo issue, I'll open a bugreport there.

evert commented 11 years ago

From evert...@gmail.com on September 12, 2011 12:20:57: Besides from how other clients behave, I'm pretty sure this is how it's supposed to be implemented. Now I don't mind adding a workaround specifically for SOGO, but it is a bug on their side.

evert commented 11 years ago

From lars.kne...@gmail.com on September 19, 2011 14:16:30: That's how I see it too. Feel free to close this issue.