Wrong tag name calendar-data => supported-calendar-data

[evert]

Original author: lars.kne...@gmail.com (September 24, 2011 06:57:03)

I think the correct tag name should be supported-calendar-data instead of calendar-data.

--- a/Sabre/CalDAV/Property/SupportedCalendarData.php +++ b/Sabre/CalDAV/Property/SupportedCalendarData.php @@ -28,7 +28,7 @@

     $prefix = isset($server->xmlNamespaces[Sabre_CalDAV_Plugin::NS_CALDAV])?$server->xmlNamespaces[Sabre_CalDAV_Plugin::NS_CALDAV]:'cal';

• $caldata = $doc->createElement($prefix . ':calendar-data');
• $caldata = $doc->createElement($prefix . ':supported-calendar-data'); $caldata->setAttribute('content-type','text/calendar'); $caldata->setAttribute('version','2.0');

Original issue: http://code.google.com/p/sabredav/issues/detail?id=155

[evert]

From evert...@gmail.com on September 24, 2011 19:11:35: No, this is in fact correct.

The xml element in 'supported-calendar-data' is 'calendar-data'. Property classes are never responsible for encoding the 'top element', but only their contents.

[evert]

From lars.kne...@gmail.com on September 25, 2011 07:26:53: Ok. That makes sense.