search

sabre-io / event

:bell: The sabre/event library provides utilities for lightweight event-based programming
http://sabre.io/event/
BSD 3-Clause "New" or "Revised" License
351 stars 21 forks source link

chore: add PHP 8.4 to CI #124

Closed phil-davis closed 1 month ago

phil-davis commented 3 months ago

Let's see if GitHub knows about PHP 8.4 alpha yet.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.18%. Comparing base (9d02602) to head (fd602f9). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #124 +/- ## ========================================= Coverage 99.18% 99.18% Complexity 111 111 ========================================= Files 7 7 Lines 370 370 ========================================= Hits 367 367 Misses 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

staabm commented 3 months ago

I would be fine with skipping cs-fixer for 8.4 for now

staabm commented 3 months ago

(or maybe we just need to update cs-fixer)

phil-davis commented 3 months ago

I would be fine with skipping cs-fixer for 8.4 for now

I just want to see if it reports anything interesting (it shouldn't!), and it passed like this.

Now to look at the phpstan deprecation messages.

phil-davis commented 3 months ago

The deprecation messages are all for vendor packages. And some are inside vendor, phpstan, vendor again - dependencies of phpstan itself.

So various dependencies need to be "fixed" first anyway.

phil-davis commented 3 months ago

See PR #126 for the 5.1 branch. We can get that approved and merged first, then I will see what finally should be done here in master.

phil-davis commented 1 month ago

See #136