fix "access array offset on value of type bool"

sabre-io / http

The sabre/http library provides utilities for dealing with http requests and responses.

http://sabre.io/http/

BSD 3-Clause "New" or "Revised" License

187 stars 62 forks source link

fix "access array offset on value of type bool" #204

Closed divinity76 closed 1 year ago

divinity76 commented 1 year ago

trying to send the request curl -X OPTIONS https://url/webdav/ to Sabre\dav 3.2.x will result in Warning: Trying to access array offset on value of type bool in C:\xampp\htdocs\webdav\vendor\sabre\http\lib\Auth\Digest.php on line 127

this is already fixed in newer versions of sabre/http, but i doubt Sabre\dav 3.2 will ever be upgraded beyond sabre\http 4.2.x, and sabre\dav 3.2 is the current release version (dav 4.x isn't released yet)

phil-davis commented 1 year ago

sabre/dav is currently at release 4.4.0 and that uses sabre/http 5.1.* (as of today, 5.1.7 is the latest in the 5.1 release series)

That still supports PHP 7.1 and up.

https://github.com/sabre-io/dav/blob/3.2/composer.json at sabre/dav 3.2 is for PHP 5.5 to 7.1 only.

And https://github.com/sabre-io/http/blob/4.2/composer.json sabre/http 4.2 is for really old PHP 5.

@divinity76 where are you needing this fix? Can you use the current sabre/dav 4 release series?

divinity76 commented 1 year ago

@phil-davis i don't even remember anymore. Don't need this fix. don't remember why I did.

IIRC i noticed the problem on a windows 7 laptop, don't remember specifics. Feel free to close this PR, but if the 4.2 branch is still maintained, i'd recommend merging (it does fix a real bug in the 4.2 branch, I think.)

phil-davis commented 1 year ago

Closing - feel free to open again if you remember details of of how a patch to the 4.2 release series could be of real help to someone.