sabre-io / http

The sabre/http library provides utilities for dealing with http requests and responses.
http://sabre.io/http/
BSD 3-Clause "New" or "Revised" License
187 stars 62 forks source link

[5.1] Prepare 5.1.9 #224

Closed phil-davis closed 1 year ago

phil-davis commented 1 year ago

We need to release this test-only change, because the released code of major version 5 contains the tests as well as the code - a piece of history. And we want to keep doing that for compatibility.

sabre/dav also runs the sabre/http unit tests in its CI (another piece of history) and the HTTP test problem in issue #222 prevents unit tests from running properly to completion. For example: https://github.com/sabre-io/dav/actions/runs/5889816355/job/15983958426?pr=1483

PHPUnit 9.6.10 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.4.33 with Xdebug 3.1.6
Configuration: tests/phpunit.xml
Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

.............................................................   61 / 1805 (  3%)
.....array(1) {
  [0]=>
  string(17) "invalid_mime_type"
}

Only 61 of 1805 test cases ran, but the CI gave it a pass.

We need to sort that out, and is a way to do it without refactoring the whole "system".