search

sabre-io / http

The sabre/http library provides utilities for dealing with http requests and responses.
http://sabre.io/http/
BSD 3-Clause "New" or "Revised" License
187 stars 62 forks source link

pin php-cs-fixer to 3.63.2 in 5.1 branch #248

Closed phil-davis closed 1 month ago

phil-davis commented 1 month ago

We still support PHP 7.1 7.2 7.3 here, and that uses the old php-cs-fixer v2. The new php-cs-fixer 3.64 wants to make changes to trailing-comma in list() - we want to avoid doing that in this old 5.1 branch, because php-cs-fixer v2 does not like it.

There is no need for any new release of the 5.1 series - https://github.com/sabre-io/http/releases/tag/5.1.12 has full support for PHP 8.4

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.14%. Comparing base (7a9f650) to head (ff1b7b9). Report is 5 commits behind head on 5.1.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 5.1 #248 +/- ## ========================================= Coverage 94.14% 94.14% Complexity 266 266 ========================================= Files 15 15 Lines 871 871 ========================================= Hits 820 820 Misses 51 51 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.