RRULE: BYWEEKNO and BYYEARDAY not respected

sabre-io / vobject

:date: The VObject library for PHP allows you to easily parse and manipulate iCalendar and vCard objects

http://sabre.io/vobject/

BSD 3-Clause "New" or "Revised" License

569 stars 125 forks source link

RRULE: BYWEEKNO and BYYEARDAY not respected #340

Closed PHPGangsta closed 8 years ago

PHPGangsta commented 8 years ago

I'm using vobject 4.1.0

I was just trying some things with BYWEEKNO and BYYEARDAY, and I saw that it's not used in the calculations. It's parsed, and put into the protected variable $this->byWeekNo / $this->byYearDay in the RRuleIterator, but it's not used anywhere. https://github.com/fruux/sabre-vobject/blob/master/lib/Recur/RRuleIterator.php#L715

I guess they should be used for calculations in the nextYearly() method.

Is there a reason that they are not implemented?

evert commented 8 years ago

There's a number of recurrence rules not implemented. The main reason is that it's a bit difficult, and most of them are unused. I've basically added them on an as-needed basis and you're the first to ask ;)

evert commented 8 years ago

Fixed via #341