search

sabre-io / vobject

:date: The VObject library for PHP allows you to easily parse and manipulate iCalendar and vCard objects
http://sabre.io/vobject/
BSD 3-Clause "New" or "Revised" License
570 stars 125 forks source link

fix issue #646 #649

Closed JohnRDOrazio closed 5 months ago

JohnRDOrazio commented 5 months ago

add lineIndex and lineString properties to a Property Node

issue #646

JohnRDOrazio commented 5 months ago

if this PR is accepted, perhaps documentation could be updated to explain how to access the properties of a node, and warn against simply trying to json_encode the resulting errors...

JohnRDOrazio commented 5 months ago

I added a Unit Test that will check for lineIndex and lineString properties when validating defective calendar data.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.78%. Comparing base (f14092f) to head (ec31757). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #649 +/- ## ========================================= Coverage 98.78% 98.78% - Complexity 1866 1868 +2 ========================================= Files 71 71 Lines 5249 5253 +4 ========================================= + Hits 5185 5189 +4 Misses 64 64 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

phil-davis commented 5 months ago

@JohnRDOrazio php-cs-fixer wants some formatting adjusted. You can: composer cs-fixer and commit and push the changes it makes.