Codecov Report

Merging #165 into master will not change coverage. The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #165   +/-   ##
=========================================
  Coverage     97.58%   97.58%           
  Complexity      112      112           
=========================================
  Files            13       13           
  Lines           456      456           
=========================================
  Hits            445      445           
  Misses           11       11

Impacted Files	Coverage Δ	Complexity Δ
lib/Service.php	`100% <100%> (ø)`	`18 <0> (ø)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update acaa763...fe9c84c. Read the comment docs.

VinceG commented 5 years ago

@evert Let me know what you want me to change. thank you.

evert commented 5 years ago

If the robots say it's good, we'll merge =)

VinceG commented 5 years ago

Looks like some failed but it's unrelated to to this change though.

evert commented 5 years ago

Agreed, thank you

VinceG commented 5 years ago

@evert Thank You! Looking forward for that tag. Thanks again.

DeepDiver1975 commented 5 years ago

Next time please squach your commits. We should try to preserve a clean commit history. THX

VinceG commented 5 years ago

@DeepDiver1975 Will do, sorry about that.

evert commented 5 years ago

I could have also done that with a press of a button. Sorry!

VinceG commented 5 years ago

@evert @DeepDiver1975 hey guys, can we have a new tag for this project? It’s been couple of months and we are still using dev-master .

sabre-io / xml

Allow passing LIB_* Options to Service Class #165

Codecov Report