sabre-io / xml

sabre/xml is an XML library that you may not hate.

http://sabre.io/xml/

BSD 3-Clause "New" or "Revised" License

516 stars 77 forks source link

Use phpunit8 #174

Closed phil-davis closed 4 years ago

phil-davis commented 4 years ago

See last commit.

This is on top of #173

codecov[bot] commented 4 years ago

Codecov Report

Merging #174 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #174   +/-   ##
=========================================
  Coverage     97.61%   97.61%           
  Complexity      112      112           
=========================================
  Files            13       13           
  Lines           461      461           
=========================================
  Hits            450      450           
  Misses           11       11

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 64c62c5...cce2c19. Read the comment docs.

staabm commented 4 years ago

This is on top of #173

hmm .. I guess I merged it in the wrong order.. could you rebase the PR?

how was I supposed to handle this situation instead?

phil-davis commented 4 years ago

how was I supposed to handle this situation instead?

I have no idea why it said that there was a conflict. I rebased and did not have to manually resolve any conflict, and the diffs look fine.

phil-davis commented 4 years ago

@staabm IMO all the "sub"-repos now have PHP 7.4 support and run phpunit8.

So whenever you like, releases can be made. And then someone can update sabre-io/dav with all the dependencies and make it support PHP 7.4 and phpunit8.

Then that will let downstream users of these packages use the new versions and officially support PHP 7.4

staabm commented 4 years ago

Thank you so much - great job. Well done