search

sabre-io / xml

sabre/xml is an XML library that you may not hate.
http://sabre.io/xml/
BSD 3-Clause "New" or "Revised" License
516 stars 77 forks source link

Use phpunit 9 where possible #179

Closed phil-davis closed 4 years ago

phil-davis commented 4 years ago

https://phpunit.de/announcements/phpunit-9.html

2nd commit: In Travis, only bother to report/upload coverage if the job actually runs unit tests with coverage enabled.

codecov[bot] commented 4 years ago

Codecov Report

Merging #179 into master will decrease coverage by 4.22%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #179      +/-   ##
============================================
- Coverage     97.61%   93.38%   -4.23%     
  Complexity      112      112              
============================================
  Files            13       15       +2     
  Lines           461      484      +23     
============================================
+ Hits            450      452       +2     
- Misses           11       32      +21
Impacted Files Coverage Δ Complexity Δ
lib/Service.php 100% <0%> (ø) 18% <0%> (ø) :arrow_down:
lib/Version.php 0% <0%> (ø) 0% <0%> (?)
lib/XmlDeserializable.php 0% <0%> (ø) 0% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 10fa155...12bb9f5. Read the comment docs.

phil-davis commented 4 years ago

codecov/project has now decided to find lib/Version.php and lib/Service.php as "new" files to it. That has just a const in it and has no unit test coverage. That is why the codecov is lower.