search

sabre-io / xml

sabre/xml is an XML library that you may not hate.
http://sabre.io/xml/
BSD 3-Clause "New" or "Revised" License
516 stars 77 forks source link

Add changelog and Version.php bump for 2.2.2 #191

Closed phil-davis closed 4 years ago

phil-davis commented 4 years ago

I forgot to do that before creating the release!

staabm commented 4 years ago

Also https://github.com/sabre-io/xml/blob/master/lib/Version.php

codecov[bot] commented 4 years ago

Codecov Report

Merging #191 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #191   +/-   ##
=========================================
  Coverage     97.65%   97.65%           
  Complexity      116      116           
=========================================
  Files            13       13           
  Lines           469      469           
=========================================
  Hits            458      458           
  Misses           11       11

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb378d8...ac1de2d. Read the comment docs.

phil-davis commented 4 years ago

@staabm should I quickly delete the "release 2.2.2" that I did? Or bump changelog and Version.php again to 2.2.3 then do a 2.2.3 release?

staabm commented 4 years ago

@staabm should I quickly delete the "release 2.2.2" that I did?

Or bump changelog and Version.php again to 2.2.3 then do a 2.2.3 release?

Feel free to re-tag .. its just a minor thing missing.. wont be a big problem for people which already have the "bogus 2.2.2" tag

as you said .. the release is pretty fresh.. no need for a 2.2.3 in this minor case