search

sabre-io / xml

sabre/xml is an XML library that you may not hate.
http://sabre.io/xml/
BSD 3-Clause "New" or "Revised" License
516 stars 77 forks source link

Allow sabre/uri major version 3 #226

Closed phil-davis closed 2 years ago

phil-davis commented 2 years ago

sabre/xml 3 already requires PHP 7.4 or later. So anyone who gets "given" sabre/xml 3 by composer has at least PHP 7.4.

"sabre/uri" : ">=1.0,<4.0.0" 1) Is there any good reason to keep the mention of sabre/uri 1.0? It feels a bit odd to keep allowing people to use such an old version of sabre/uri with sabre/xml

Answer: dropped.

2) What version bump should we do in sabre/xml when we release this change - I guess someone might notice the Windows file path behavior change in sabre/uri if they auto-magically get the new major version. But they can also easily mention sabre/uri major version 2 in their own composer.json if they themselves depend on sabre/uri - so is the next sabre/xml just a patch, a minor or a major release?

Answer: I will release a new major version, to be safe.

codecov[bot] commented 2 years ago

Codecov Report

Merging #226 (a63bb52) into master (52fbace) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #226   +/-   ##
=========================================
  Coverage     96.68%   96.68%           
  Complexity      116      116           
=========================================
  Files            13       13           
  Lines           453      453           
=========================================
  Hits            438      438           
  Misses           15       15

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

staabm commented 2 years ago

agree.

doing a new major version, because of the BC problems in sabre/uri seems like a good idea. dropping sabre/uri 1.x in the same steps sounds great as well.

better save then sorry.