sabre-io / xml

sabre/xml is an XML library that you may not hate.
http://sabre.io/xml/
BSD 3-Clause "New" or "Revised" License
516 stars 77 forks source link

Adjust code style to meet current php-cs-fixer #231

Closed phil-davis closed 1 year ago

phil-davis commented 1 year ago

php-cs-fixer is reporting these. I guess there has been a newer php-cs-fixer version released that is different.

It wants "root" classes and functions to use the leading \ - \DateTime.

We could change some php-cs-fixer rule settings, but actually it is easy to accept these code-style changes.

codecov[bot] commented 1 year ago

Codecov Report

Merging #231 (263ad72) into master (5051b30) will increase coverage by 0.21%. The diff coverage is 80.00%.

@@             Coverage Diff              @@
##             master     #231      +/-   ##
============================================
+ Coverage     96.68%   96.90%   +0.21%     
  Complexity      116      116              
============================================
  Files            13       13              
  Lines           453      485      +32     
============================================
+ Hits            438      470      +32     
  Misses           15       15              
Impacted Files Coverage Δ
lib/Writer.php 100.00% <ø> (ø)
lib/Serializer/functions.php 97.77% <66.66%> (ø)
lib/LibXMLException.php 100.00% <100.00%> (ø)
lib/Reader.php 97.50% <100.00%> (+0.08%) :arrow_up:
lib/Element/Uri.php 100.00% <0.00%> (ø)
lib/ContextStackTrait.php 100.00% <0.00%> (ø)
lib/Element/XmlFragment.php 100.00% <0.00%> (ø)
lib/Service.php 98.59% <0.00%> (+0.13%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more