sabre-io / xml

sabre/xml is an XML library that you may not hate.
http://sabre.io/xml/
BSD 3-Clause "New" or "Revised" License
515 stars 77 forks source link

Cs fixer CI changes v3 #239

Closed phil-davis closed 1 year ago

phil-davis commented 1 year ago

php-cs-fixer now wants various changes. I have got most of this from what is in master branch (major version 4) and applied it to the major version 3 branch. See master PRs #231 #233 #234 #236 #238

codecov[bot] commented 1 year ago

Codecov Report

Merging #239 (b1504f3) into v3 (5f9d8c1) will increase coverage by 0.21%. The diff coverage is 80.00%.

@@             Coverage Diff              @@
##                 v3     #239      +/-   ##
============================================
+ Coverage     96.68%   96.90%   +0.21%     
  Complexity      116      116              
============================================
  Files            13       13              
  Lines           453      485      +32     
============================================
+ Hits            438      470      +32     
  Misses           15       15              
Impacted Files Coverage Δ
lib/Deserializer/functions.php 89.69% <ø> (ø)
lib/Element/Base.php 100.00% <ø> (ø)
lib/Element/Uri.php 100.00% <ø> (ø)
lib/Service.php 98.59% <ø> (+0.13%) :arrow_up:
lib/Writer.php 100.00% <ø> (ø)
lib/Serializer/functions.php 97.77% <66.66%> (ø)
lib/LibXMLException.php 100.00% <100.00%> (ø)
lib/Reader.php 97.50% <100.00%> (+0.08%) :arrow_up:

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

phil-davis commented 1 year ago

After PR #238 is merged, I will sort this out to make similar changes for major version 3.

phil-davis commented 1 year ago

@staabm this gets the major version 3 branch up-to-date with all the tools... That will allow patch releases 3.0.* to be made out of the v3 branch as needed. (an major version 4 patch releases come from master)