search

sabre-io / xml

sabre/xml is an XML library that you may not hate.
http://sabre.io/xml/
BSD 3-Clause "New" or "Revised" License
515 stars 77 forks source link

[v3] Fixed error where valueobject has eaten too much #241

Closed phil-davis closed 1 year ago

phil-davis commented 1 year ago

This fixes a bug, when valueobject is an empty element like In this situation the deserializer did read one more, thus ending up a level higher than required

Backport to v3 branch.

codecov[bot] commented 1 year ago

Codecov Report

Merging #241 (5393c72) into v3 (5f9d8c1) will increase coverage by 0.21%. The diff coverage is n/a.

@@             Coverage Diff              @@
##                 v3     #241      +/-   ##
============================================
+ Coverage     96.68%   96.90%   +0.21%     
  Complexity      116      116              
============================================
  Files            13       13              
  Lines           453      485      +32     
============================================
+ Hits            438      470      +32     
  Misses           15       15
Impacted Files Coverage Δ
lib/Deserializer/functions.php 89.69% <ø> (ø)

... and 9 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more