[2.1] Valueobject runaway v2.1

sabre-io / xml

sabre/xml is an XML library that you may not hate.

http://sabre.io/xml/

BSD 3-Clause "New" or "Revised" License

515 stars 77 forks source link

[2.1] Valueobject runaway v2.1 #242

Closed phil-davis closed 1 year ago

phil-davis commented 1 year ago

This fixes a bug, when valueobject is an empty element like In this situation the deserializer did read one more, thus ending up a level higher than required

Backport PR #229 to 2.1 branch.

phil-davis commented 1 year ago

This old branch has Travis CI (which does not run any more) I ran the unit tests locally with PHP 7.4

phil@phil-Inspiron-5468:~/git/sabre-io/xml$ ./bin/phpunit --configuration tests/phpunit.xml.dist
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.

...............................................................  63 / 108 ( 58%)
.............................................                   108 / 108 (100%)

Time: 348 ms, Memory: 6.00MB

OK (108 tests, 126 assertions)

phil-davis commented 1 year ago

Actually we do not need this. There is a 2.2.* release series. I created a 2.2 branch at the 2.2.5 tag. See PR #243 which adds the bugfix there.