search

sabre-io / xml

sabre/xml is an XML library that you may not hate.
http://sabre.io/xml/
BSD 3-Clause "New" or "Revised" License
515 stars 77 forks source link

[2.2] Fixed error where valueobject has eaten too much #243

Closed phil-davis closed 1 year ago

phil-davis commented 1 year ago

This fixes a bug, when valueobject is an empty element like In this situation the deserializer did read one more, thus ending up a level higher than required

Backport #229 to 2.2 branch

codecov[bot] commented 1 year ago

Codecov Report

Merging #243 (1db2950) into 2.2 (a6af111) will increase coverage by 0.14%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.2     #243      +/-   ##
============================================
+ Coverage     96.90%   97.05%   +0.14%     
  Complexity      116      116              
============================================
  Files            13       13              
  Lines           485      509      +24     
============================================
+ Hits            470      494      +24     
  Misses           15       15
Impacted Files Coverage Δ
lib/Deserializer/functions.php 89.69% <100.00%> (ø)

... and 6 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more