search

sabre-io / xml

sabre/xml is an XML library that you may not hate.
http://sabre.io/xml/
BSD 3-Clause "New" or "Revised" License
515 stars 77 forks source link

Enhance PHPdoc of Service write value parameter #247

Closed phil-davis closed 1 year ago

phil-davis commented 1 year ago

Fixes #237

This makes the PHPdoc of Service write allow an array with integer keys to be passed in the value parameter. That is passed to: $w->writeElement($rootElementName, $value);

And Writer writeElement already has PHPdoc that allows array<int|string, mixed>

codecov[bot] commented 1 year ago

Codecov Report

Merging #247 (c2547e2) into master (c4cec17) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #247   +/-   ##
=========================================
  Coverage     96.90%   96.90%           
  Complexity      116      116           
=========================================
  Files            13       13           
  Lines           485      485           
=========================================
  Hits            470      470           
  Misses           15       15
Impacted Files Coverage Δ
lib/Service.php 98.59% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more