search

sabre-io / xml

sabre/xml is an XML library that you may not hate.
http://sabre.io/xml/
BSD 3-Clause "New" or "Revised" License
515 stars 77 forks source link

fix: return type of XmlFragment::xmlDeserialize to match base declara… #258

Closed DeepDiver1975 closed 10 months ago

DeepDiver1975 commented 10 months ago

…tion

XmlDeserializable::xmlDeserialize has no return type defined as well and any sub-class of XmlFragment will also return mixed - see various xml classes in sabre/dav

refs https://github.com/sabre-io/xml/blob/4689ae198bb1ab9a2598720a2ccfc7963210b06b/lib/XmlDeserializable.php#L37

codecov[bot] commented 10 months ago

Codecov Report

Merging #258 (f273a8c) into master (a0de970) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #258   +/-   ##
=========================================
  Coverage     96.75%   96.75%           
  Complexity      115      115           
=========================================
  Files            13       13           
  Lines           493      493           
=========================================
  Hits            477      477           
  Misses           16       16
Files Coverage Δ
lib/Element/XmlFragment.php 100.00% <100.00%> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!