search

sabre-io / xml

sabre/xml is an XML library that you may not hate.
http://sabre.io/xml/
BSD 3-Clause "New" or "Revised" License
516 stars 77 forks source link

chore: use php-cs-fixer 3.51 #271

Closed phil-davis closed 7 months ago

phil-davis commented 8 months ago

php-cs-fixer 3.49 (or some recent minor release) wants to use the ? (nullable) syntax on optional parameters. That syntax has been supported for quite a while since PHP https://www.php.net/manual/en/migration71.new-features.php

In the cases here, as well as the default value of the parameter being null, the ? explicitly allows the caller to pass the value null if they want.

This seems reasonable, I don't see how it can break any existing usage.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.69%. Comparing base (11997fd) to head (c01b1e2). Report is 5 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #271 +/- ## ============================================ - Coverage 96.75% 96.69% -0.07% Complexity 115 115 ============================================ Files 13 13 Lines 493 484 -9 ============================================ - Hits 477 468 -9 Misses 16 16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

phil-davis commented 8 months ago

Has a minor complaint about project code coverage - strange report, the codecov/patch reports 100% of diff hit.

phil-davis commented 7 months ago

Bumped to use cs-fixer 3.51