Add PHP 8.4 compliance for 2.2 branch

phil-davis commented 2 months ago

keep running cs-fixer just on the oldest supported PHP 7.1 (it does a little bit different spacing for call-by-reference parameters if I run it in PHP 8)
run phpstan in both PHP 7.1 and PHP 8.4 to (hopefully) find all the "interesting" things
adjust nullable parameters to explictly have the ? to keep PHP 8.4 happy
- turn off reportUnmatchedIgnoredErrors in PHPstan. PHPstan, when run in PHP 7.1, thinks that a call to startElementNs has a problem. But, when run with PHP 8.4, it correctly understands that the call is fine. So we don't want to report the unmatched ignored error.
specify the current minor version of PHP 9 (9.6) just so that it is explicit that 9.6.x should be used

phil-davis commented 2 months ago

@cedric-anne here is what seems to be needed for https://github.com/sabre-io/xml 2.2 release series.

When this has been approved, I will apply similar to the later major release series.

cedric-anne commented 2 months ago

Hi @phil-davis

This is weird, the 2.2.8 version cannot be downloade by composer, because it is not listed in https://repo.packagist.org/p2/sabre/xml.json . However, this version is present in the corresponding packagist page https://packagist.org/packages/sabre/xml#2.2.8.

sabre-io / xml