Closed phil-davis closed 1 month ago
Attention: Patch coverage is 75.00000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 96.07%. Comparing base (
a476c68
) to head (e9eca39
). Report is 21 commits behind head on 2.2.
Files with missing lines | Patch % | Lines |
---|---|---|
lib/Service.php | 75.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Backport the code related to issue #297 from PR #296 to the 2.2 branch.
~And apply code-style changes that the latest php-cs-fixer 3.64 makes.~
php-cs-fixer 3.64 wants to apply trailing-comma to
list(a,b,c,)
as part of the latestSymfony
code style. The old php-cs-fixer v2 does not know about that. So for this 2.2 branch we can lock the new php-cs-fixer to 3.63.2 so that it does not do any code-style changes. That lets the CI pass.In future we will probably drop the support for PHP 7.1 7.2 7.3 and therefore can stop using php-cs-fixer v2. I will do that for a 2.3 series "some day".