sabre-io / xml

sabre/xml is an XML library that you may not hate.
http://sabre.io/xml/
BSD 3-Clause "New" or "Revised" License
516 stars 77 forks source link

Backport fix for "Passing a closed resource to Service parse or expect" to 2.2 #298

Closed phil-davis closed 1 month ago

phil-davis commented 1 month ago

Backport the code related to issue #297 from PR #296 to the 2.2 branch.

~And apply code-style changes that the latest php-cs-fixer 3.64 makes.~

php-cs-fixer 3.64 wants to apply trailing-comma to list(a,b,c,) as part of the latest Symfony code style. The old php-cs-fixer v2 does not know about that. So for this 2.2 branch we can lock the new php-cs-fixer to 3.63.2 so that it does not do any code-style changes. That lets the CI pass.

In future we will probably drop the support for PHP 7.1 7.2 7.3 and therefore can stop using php-cs-fixer v2. I will do that for a 2.3 series "some day".

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.07%. Comparing base (a476c68) to head (e9eca39). Report is 21 commits behind head on 2.2.

Files with missing lines Patch % Lines
lib/Service.php 75.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.2 #298 +/- ## ============================================ - Coverage 97.06% 96.07% -1.00% - Complexity 116 124 +8 ============================================ Files 13 13 Lines 511 484 -27 ============================================ - Hits 496 465 -31 - Misses 15 19 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.