search

sabre-io / xml

sabre/xml is an XML library that you may not hate.
http://sabre.io/xml/
BSD 3-Clause "New" or "Revised" License
516 stars 77 forks source link

added a new namespaceAware() deserializer function #62

Closed staabm closed 8 years ago

staabm commented 8 years ago

didnt found the comments in which we discussed this topic therefore starting from scratch. hopefully all points are adressed.

evert commented 8 years ago

I think I want to change the behavior of the function a little bit. Instead of :

Sabre\Xml\Deserialize\namespaceAware, I think I just want to call it Sabre\Xml\Deserializer\keyValue.

By default I want to give it the same behavior as Sabre\Xml\Element\KeyValue, but if you specify the $namespace argument (which will be optional) it will strip the namespace, but only from the elements within that namespace, and leave the others intact.

So basically, hold on a second. I will take your PR and use it as a basis for this =)

staabm commented 8 years ago

Sounds great!

evert commented 8 years ago

Oh I didn't realize that in your PR you're already retaining other elements outside of the specified namespace. Really awesome. In that case I'm only changing the function name and docblocks ;)