sabre1041 / openshift-flexvolume-cifs

FlexVolume driver for access CIFS based shares
14 stars 8 forks source link

Missguiding Credential order in cifs-secret-template.yml #7

Open pRncs opened 3 years ago

pRncs commented 3 years ago

Hi, first of all I'd like to thank you for your good work!

It's not really an issue, but I just spent hours finding my mistake: In the example secret file cifs-secret-template.yml you first listed password and then username. This is quite counter intuitive. I absent minded copy pasted the username to password and the password to the username.

Better would be:

stringData:
  username: "${USERNAME}"
  password: "${PASSWORD}"

Cheers!