search

sabre1041 / openshift-logforwarding-splunk

Demonstration of forwarding logs from OpenShift to Splunk
Apache License 2.0
30 stars 26 forks source link

some templates don't include namespace #17

Closed mortya closed 2 years ago

mortya commented 2 years ago

Some of the templates don't set metadata.namespace.

This doesn't matter if you deploy directly with helm, because helm automatically sets the context to the namespace before applying the yaml. But if you use helm template to generate yaml for deployment with some other tool, the generated yaml then gets deployed incorrectly.

sabre1041 commented 2 years ago

@mortya Pushed https://github.com/sabre1041/openshift-logforwarding-splunk/commit/88bce81903d8b4f49a0be08eb68aa16d23a8d4a0 which should account for these concerns

mortya commented 2 years ago

Thank you! Looking good.