search

sabrina-aip / spellcheck

a very silly spelling bee game
74 stars 36 forks source link

fix result unreadable for colourblind #31

Open jasger9000 opened 5 months ago

jasger9000 commented 5 months ago

Hello again,

This PR is meant to fix the result page being hard/impossible to use for colour-blind people because the emojis are difficult to differentiate.

Since I'm not colour-blind myself, it would be really great if @q00u would have a look at it since they raised the issue initially from what I can tell. Any other feedback would also be greatly appreciated.

Before

before

Copied

Spellcheck #21 🟩🟩🟩🟩🟩 🟥🟩🟩🟥🟩 🟩🟩🟩🟥🟩

After

after

Copied

Spellcheck #21 ✅✅✅✅✅ ✅✅✅❌❌ ✅✅✅✅❌

q00u commented 5 months ago

Definitely readable and unambiguous no matter what kind of colorblindness (though I still like the softer blocks vs the checkmarks, if only it were red and blue)

In some cultures, the checkmark means wrong, and a circle is used for 'correct', but then again, this is about English, so maybe that doesn't matter

jasger9000 commented 5 months ago

though I still like the softer blocks vs the checkmarks

I could add blocks around the checkmarks and crosses, so the symbol would be black on a coloured cube.

if only it were red and blue

I think blue would be confusing for the majority of people, since green is usually associated with 'correct'

jasger9000 commented 5 months ago

I could add blocks around the checkmarks and crosses, so the symbol would be black on a coloured cube.

@q00u After a bit of messing with the width, this is what I came up with:

after