Closed GoogleCodeExporter closed 9 years ago
The patch has been reviewed and the following changes have been made:
- configuration keywords are now used instead of hardcoded values to specify
expected running time as well as allowed delay. Example values of the revelant
keywords, as chosen by Namshin, have been added to pyggrc.example;
- abnormalStop was set on failure rather than success, which was inconsistent with
how it was used elsewhere in the file. Fixed;
- in the pass-or-fail test the expected value of abnormalStop was still 2, should
now be 3. Fixed;
- reformatted the comment and the output message a bit.
That aside, the new feature works well and I consider it important. Nominated
for
inclusion into the master!
Original comment by mare...@gmail.com
on 1 Apr 2009 at 4:52
Attachments:
Chris had a look at the code yesterday and committed it to the master. Issue
closed!
Original comment by mare...@gmail.com
on 7 Apr 2009 at 10:55
Original issue reported on code.google.com by
mare...@gmail.com
on 31 Mar 2009 at 4:27Attachments: