sabrinadeltoro / pygr

Automatically exported from code.google.com/p/pygr
0 stars 0 forks source link

Track running time of megatests #83

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
One thing which megatest reports in their present form lack is some sort 
of automatic reporting of the tests having suddenly taken too long - which 
come to think of it would really be useful, given tracking running time is 
the whole purpose of these tests :-) Attached you will find a patch from 
Namshin, originally posted in Issue 69, which introduces this sort of 
monitoring and reports if megatests run longer than 20 minutes, using the 
time of 11 minutes as reference. 

I shall review the patch and post an updated version soon.

Original issue reported on code.google.com by mare...@gmail.com on 31 Mar 2009 at 4:27

Attachments:

GoogleCodeExporter commented 9 years ago
The patch has been reviewed and the following changes have been made:
  - configuration keywords are now used instead of hardcoded values to specify 
expected running time as well as allowed delay. Example values of the revelant 
keywords, as chosen by Namshin, have been added to pyggrc.example;
  - abnormalStop was set on failure rather than success, which was inconsistent with 
how it was used elsewhere in the file. Fixed;
  - in the pass-or-fail test the expected value of abnormalStop was still 2, should 
now be 3. Fixed;
  - reformatted the comment and the output message a bit.

That aside, the new feature works well and I consider it important. Nominated 
for 
inclusion into the master!

Original comment by mare...@gmail.com on 1 Apr 2009 at 4:52

Attachments:

GoogleCodeExporter commented 9 years ago
Chris had a look at the code yesterday and committed it to the master. Issue 
closed!

Original comment by mare...@gmail.com on 7 Apr 2009 at 10:55