search

sabuhish / fastapi-mail

Fastapi mail system sending mails(individual, bulk) attachments(individual, bulk)
https://sabuhish.github.io/fastapi-mail/
MIT License
698 stars 81 forks source link

Fixes #128: Content-Disposition Header Gets Ignored. #129

Closed dvuckovic closed 2 years ago

dvuckovic commented 2 years ago

By moving the implicit addition of Content-Dispositionto after all explicit headers were included for an attachment, we can check if it already exists. A test case was extended to cover this behavior.

sabuhish commented 2 years ago

Thanks for your PR, that will solve the issue with Content-Disposition. I would kindly ask you, if you could document it, in order to keep this in the doc, in case if someone also faces the same issue. Thanks again!

dvuckovic commented 2 years ago

@sabuhish Good point! I adjusted the existing example, since it's related to an inline image anyway. Let me know if you need anything else.

sabuhish commented 2 years ago

Perfect! Thanks for your work!