search

sabuhish / fastapi-mail

Fastapi mail system sending mails(individual, bulk) attachments(individual, bulk)
https://sabuhish.github.io/fastapi-mail/
MIT License
680 stars 82 forks source link

Dependencies. Can it be cleaner? #130

Closed maxzhenzhera closed 2 years ago

maxzhenzhera commented 2 years ago

List of the current dependencies from pyproject.toml:

[tool.poetry.dependencies]
python = "^3.6.2"   
fastapi = "0.*" 
Jinja2 = "^3.0.1"
aiosmtplib = "^1.1.6"
pydantic = "^1.8.2"
email-validator = "^1.1.3"
aioredis = "^2.0.0"
httpx = "0.*"
blinker = "^1.4"
fakeredis = "^1.*"
python-multipart = "^0.0.5"

aioredis and httpx are used only in utils. I think it could be optional. fakeredis is used only in tests. I think it could be in dev dependencies. fastapi and python-multipart are not used directly at all.

Please, explain to me, why we have so many required dependencies?

sabuhish commented 2 years ago

Hi @maxzhenzheram, you are right, I have thought about this also, during development we were using these libraries, and we moved to poetry on this PR #89 I realized these dependencies later. I will make another PR that moves these dependencies to the dev dependencies, thanks for pointing out this.

sabuhish commented 2 years ago

Done!

aryadovoy commented 1 year ago

Still no support email-validator>2.0. Could you add, please?