Closed tammoippen closed 1 year ago
Hi @tammoippen
Ups, that that fakeredis
was not suppose to be optional, I misconfigured it. aioredis
must be the optional to be installed.
Meaning both httpx
and aioredis
can be installed as an extra dependency. When installing fastapi-mail
it wont be installed. Those should be installed with the following commands:
pip install fastapi-mail[aioredis]
pip install fastapi-mail[httpx]
I have opened branch currently working on it, will submit PR and merge it to the master soon. Thanks!
Hi there, agian :D
I think there might be some dependency hiccups:
[tool.poetry.dependencies]
you havefakeredis
(also as a optional dep), but in the library code you do not use it. Also,fakeredis
is already part of the[tool.poetry.dev-dependencies]
(where it belongs). hereaioredis
is only part of[tool.poetry.dev-dependencies]
, even though it is used inemail_check
- making that part of the code unusable for external projects (except they install aioredis themself as a peer dependency)Thanks again for the library!