sabuhish / fastapi-mail

Fastapi mail system sending mails(individual, bulk) attachments(individual, bulk)
https://sabuhish.github.io/fastapi-mail/
MIT License
680 stars 82 forks source link

Can't upgrade to fastapi==0.88.0 because "fastapi-mail 1.2.2 depends on starlette<0.22.0" #161

Closed ilBEastli closed 1 year ago

ilBEastli commented 1 year ago

The same problem as in previous issue https://github.com/sabuhish/fastapi-mail/issues/157 but for the next version of the library. Do you consider to make less restrictive version dependency? 🙏🏻

elpacificmb commented 1 year ago

For your code to work, you need to force your requirements.txt to fastapi==0.86.0 and starlette==0.20.4, with that in place, you will have no issue for now.

ilBEastli commented 1 year ago

Yep but it keeps me and other users on old versions of libraries. That's pretty sad :(

gbiz123 commented 1 year ago

I was able to resolve this with pip install fastapi=0.87.0 in a virtual environment

ssproessig-thales commented 1 year ago

maybe solved with #167

theshohidul commented 1 year ago

Could you please consider making a less restrictive version dependency?

sabuhish commented 1 year ago

Hi there! could you guys please check version 1.2.4?

rambo commented 1 year ago

The caret version specifier is overly strict for 0.x versions, see https://github.com/python-gino/gino-starlette/pull/38 for details.

I also do not understand why python version is set to ^3.8.1 I could understand some much higher patch revision of 3.8 if it was really needed but .1 ?

edit: found the reason, flake8 is being difficult

rememberlenny commented 1 year ago

Can we go to 0.89.*?

rambo commented 1 year ago

@rememberlenny my PR hasvery loose starlette requirements (and there is no explicit requirement for fastapi version, the issues come from starlette version binds).

sabuhish commented 1 year ago

@rambo if your statements prove it I would be pleased about it, I thought I made it less restrictive on fastapi, but it seems like this issue arises again and again. Thanks for your work, will release a new version of the library.