sacOO7 / socketcluster-client-go

GO client for socketcluster
https://socketcluster.io/
Apache License 2.0
55 stars 20 forks source link

Fix not handling conversion #16

Closed happilymarrieddad closed 10 months ago

happilymarrieddad commented 10 months ago

This is the error I'm encountering

2023/09/21 15:37:13 {"rid":2}
2023/09/21 15:37:21
panic: interface conversion: interface {} is nil, not map[string]interface {}

goroutine 22 [running]:
github.com/sacOO7/socketcluster-client-go/scclient/parser.GetMessageDetails({0x0?, 0x0?})
    /Users/nkotenberg/go/pkg/mod/github.com/sac!o!o7/socketcluster-client-go@v1.0.0/scclient/parser/parser.go:28 +0x236
github.com/sacOO7/socketcluster-client-go/scclient.(*Client).Connect.(*Client).registerCallbacks.func3({0x0, 0x0}, {0xc0003886e0, 0xc000482000, {0x1422697, 0x22}, {0x0, 0x1, 0x0, {0x0, ...}}, ...})
    /Users/nkotenberg/go/pkg/mod/github.com/sac!o!o7/socketcluster-client-go@v1.0.0/scclient/client.go:65 +0xe7
github.com/sacOO7/gowebsocket.(*Socket).Connect.func4()
    /Users/nkotenberg/go/pkg/mod/github.com/sac!o!o7/gowebsocket@v0.0.0-20221109081133-70ac927be105/gowebsocket.go:156 +0x2f8
created by github.com/sacOO7/gowebsocket.(*Socket).Connect in goroutine 19
    /Users/nkotenberg/go/pkg/mod/github.com/sac!o!o7/gowebsocket@v0.0.0-20221109081133-70ac927be105/gowebsocket.go:135 +0x799
exit status 2
☁  api

So dep isn't available anymore and has been deprecated since 2020 which makes testing very hard. I've updated to go mod. This PR also fixes the above error. Conversions should handle the possible failure case and now it does. Hopefully that makes sense. I need this for a work project so I hoping we can get this worked out. Thanks!

sacOO7 commented 10 months ago

Thanks for the PR 👍