search

sacOO7 / socketcluster-client-java

Native java and android client for socketcluster framework in node.js
http://socketcluster.io/
Apache License 2.0
94 stars 42 forks source link

Upgrade Neovisionaries socket library #45

Open SanderVeer opened 5 years ago

SanderVeer commented 5 years ago

Currently the library is using a nv-socket lib version that's 8 version behind the latest one. This means the library is missing (important) features such as SNI support which is currently causing me a lot of issues on an app supporting older Android APIs.

Please upgrade the lib to use a more recent version of the Neovisionaries socket library.

sacOO7 commented 5 years ago

Hi @SanderGemoro I am really sorry for delay. Expect update from me on this till tomorrow.

SanderVeer commented 5 years ago

Hi @sacOO7 , any new updates on this front or the OkHttp socket conversion? Really looking forward to it :D

sacOO7 commented 5 years ago

Hey I will push the minimal okhttp based websocket version today 👍

On Tue, Dec 4, 2018, 3:02 PM SanderGemoro notifications@github.com wrote:

Hi @sacOO7 https://github.com/sacOO7 , any new updates on this front or the OkHttp socket conversion? Really looking forward to it :D

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sacOO7/socketcluster-client-java/issues/45#issuecomment-444032307, or mute the thread https://github.com/notifications/unsubscribe-auth/AP8vScJdexD-iaSWVL5FlK_AwIm-DIdXks5u1kEUgaJpZM4YmKC6 .

sacOO7 commented 5 years ago

Hi @SanderGemoro , I have updated the library today. You can see code on the branch here https://github.com/sacOO7/socketcluster-client-java/tree/feature/okHTTP. Will release unofficial version of library for beta testing. Keep watching repo. for more updates.

sacOO7 commented 5 years ago

Hi @SanderGemoro , I have published beta version related to above code. You can include it in your code by using

compile 'io.github.sac:SocketclusterClientJava:2.0.0-beta'

There are some method signatures which got changed due to change in library. But, you should be able to fix it without any problem. Please let me know if you face any problems with this latest release.

sacOO7 commented 5 years ago

Hi @SanderGemoro , any updates on above?

SanderVeer commented 5 years ago

I havent worked on this part in our project since your last update so I haven't had the time to try it out yet. I'll probably be able to give an update tomorrow! Thanks for your hard work!

sacOO7 commented 5 years ago

Ok np...

SanderVeer commented 5 years ago

Hey @sacOO7 , I just tried out your new beta client and it solved all of our issues instantly! Like you said we did have to make some minor changes but that was a piece of cake. Our chat solution now works perfectly on devices running API 21 and up

mike-holberger commented 5 years ago

Wow I am really looking forward to the OkHttp release too! I will be testing out the beta release for now.