search

saccarosium / shell-velocity

A portable notational velocity for your shell written in POSIX shell.
MIT License
32 stars 5 forks source link

Feat add extensions #1

Closed mattmc3 closed 1 year ago

mattmc3 commented 1 year ago

This PR fixes the English spelling of some words in the readme. It also adds support for a new variable - SHV_MORE_EXTS. This variable allows the user to add additional extensions to the fuzzy finder, essentially supporting any number of legacy text documents. New docs are still created using the SHV_EXT extension.

saccarosium commented 1 year ago

Thanks for the PR, it is really appreciated! If you make that small modification I would love to merge this.

mattmc3 commented 1 year ago

If you make that small modification I would love to merge this.

Sorry, I'm not seeing the modification you're referring to. Did you add a code review comment I'm missing?

saccarosium commented 1 year ago

If you make that small modification I would love to merge this.

Sorry, I'm not seeing the modification you're referring to. Did you add a code review comment I'm missing?

Weird, I've commented the code you should be able to see it.

saccarosium commented 1 year ago

btw @mattmc3 the comment was only about merge SHV_MORE_EXTS and SHV_EXT in a single varible like SHV_EXTS and use the first extention as the primary extention, and save it into a variable called EXT. You can declare EXT like so:

EXT=$(echo "$SHV_EXTS" | cut -d' ' -f1)
mattmc3 commented 1 year ago

That's a great idea. I pushed another commit. It's a slight variation on what you asked for, so if it's not quite what you were hoping for, hit me up.

saccarosium commented 1 year ago

I merge this. Thanks for your contribution!