saccarosium / shell-velocity

A portable notational velocity for your shell written in POSIX shell.
MIT License
32 stars 5 forks source link

replace by user set grepper #8

Closed Konfekt closed 9 months ago

Konfekt commented 9 months ago

Thank you for this useful tool! Would it not be sensible (or maybe rather overkill?) to use a common grepper such as ripgrep (as in https://github.com/alok/notational-fzf-vim) and fall back to grep to implement https://github.com/saccarosium/shell-velocity/blob/f84beddce472d9f6cbdece923fa64b6cdca1152a/shv#L87 ?

saccarosium commented 9 months ago

It is probably better I expose a variable to change the grep command. With a little of logic to use ripgrep if available.