sacdallago / bio_embeddings

Get protein embeddings from protein sequences
http://docs.bioembeddings.com
MIT License
461 stars 65 forks source link

files should terminate in _file #154

Closed sacdallago closed 3 years ago

sacdallago commented 3 years ago

I noticed we have this: https://github.com/sacdallago/bio_embeddings/blob/develop/bio_embeddings/utilities/defaults.yml#L63 which slipped my attention at the review stage.

The reason I have files end in _file and directories end in _directory is that this way the output .yml of every stage / of the entire pipeline has either paths where the keys end in _file or _directory, otherwise values.

This potentially facilitates IO at the end, e.g. in the webserver.

For the above case, I would change from model_file_X to model_X_file