search

sachac / subed

subed is a subtitle editor for Emacs
177 stars 16 forks source link

Add tests/test-subed-vtt.el #27

Closed sachac closed 3 years ago

sachac commented 3 years ago

Some tests, maybe? =)

rndusr commented 3 years ago

Yes, please! :)

But that commit doesn't do what the PR says. :(

sachac commented 3 years ago

Hah, wait, I suck at Git when I'm doing it late at night. I'll look at it tonight.

On Fri., Dec. 25, 2020, 10:20 rndusr, notifications@github.com wrote:

Yes, please! :)

But that commit doesn't do what the PR says. :(

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rndusr/subed/pull/27#issuecomment-751262315, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACD7ER2PCVB44GQTTC4X7TSWSUTLANCNFSM4VI4UVSA .

sachac commented 3 years ago

Oh, I'm a little confused. It adds tests/test-subed-vtt.el and fixes some things in subed-vtt.el so that make test works, doesn't it?

sachac commented 3 years ago

(And of course, no rush. Feel free to take your time, and happy holidays! =) )

rndusr commented 3 years ago

Sorry, my bad!

I looked at the commit on the website with Javascript disabled. The fixes in subed-vtt.el were displayed, but the added test-subed-vtt.el wasn't.

I'll take a closer look after getting some sleep.

rndusr commented 3 years ago

Sorry about the delay.

I also noticed I forgot to push your other stuff.

Let me know if I messed up anything else.

sachac commented 3 years ago

Looks pretty good to me. :) Thanks for working on this and making a nice, solid package!

On Sun., Dec. 27, 2020, 16:08 rndusr, notifications@github.com wrote:

Sorry about the delay.

I also noticed I forgot to push your other stuff.

Let me know if I messed up anything else.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rndusr/subed/pull/27#issuecomment-751516254, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACD7ESZCBIZ6DVWBTUIA4TSW6O57ANCNFSM4VI4UVSA .