search

sachac / subed

subed is a subtitle editor for Emacs
177 stars 16 forks source link

Add tests for subed-split-subtitle #33

Closed sachac closed 3 years ago

sachac commented 3 years ago

What do you think about these tests? Sorry about the multiple commits. Do you need me to figure out how to combine them?

rndusr commented 3 years ago

Thank you. Looks like you actually squashed some bugs. Yay!

Side note: Your commits weren't too messy, but if you don't know about rebasing and staging individual lines in magit, you should definitely look into that. It takes only a few seconds to combine, split or otherwise fix a commit.

sachac commented 3 years ago

I wasn't sure if people had already pulled from the branch I pushed to Github, and I noticed mistakes only after I pushed. :) I think rebase + force got us into that mess the last time! Maybe next time I'll make a new branch.

On Thu., Mar. 18, 2021, 06:47 rndusr, @.***> wrote:

Thank you. Looks like you actually squashed some bugs. Yay!

Side note: Your commits weren't too messy, but if you don't know about rebasing and staging individual lines in magit, you should definitely look into that. It takes only a few seconds to combine, split or otherwise fix a commit.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rndusr/subed/pull/33#issuecomment-801820934, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACD7ERSF5YLIFDTTIOVQO3TEHK25ANCNFSM4ZLV6MCA .