search

sachac / subed

subed is a subtitle editor for Emacs
177 stars 16 forks source link

Add functions to insert HTML-like tags #37

Closed mbork closed 3 years ago

mbork commented 3 years ago

I am open to suggestions re: the keybindings. The C-c C-e one was inspired by AUCTeX, but maybe another ones would be better.

rndusr commented 3 years ago

Feels like it's working perfectly. Thank you.

I actually have some thoughts about the keybindings. I would've done something like this:

C-c C-t C-t - subed-insert-html-tag C-c C-t C-i - subed-insert-html-tag-italic C-c C-t C-b - subed-insert-html-tag-bold

With subed-insert-default-html-tag, I can only have one frequently used tag. I'm not very familiar with commonly used tags, so this may be ok.

My proposal has the drawback of adding another keystroke, but it is more intuitive in my opinion. We can bind keys for multiple tags and users can add any number of custom tags with a relatively small function.

mbork commented 3 years ago

On 2021-05-27, at 11:49, rndusr @.***> wrote:

C-c C-t C-t - subed-insert-html-tag C-c C-t C-i - subed-insert-html-tag-italic C-c C-t C-b - subed-insert-html-tag-bold

Done, thanks!

-- Marcin Borkowski http://mbork.pl

rndusr commented 3 years ago

Works like a charm. Thank you.