search

sachac / subed

subed is a subtitle editor for Emacs
177 stars 16 forks source link

Make hours optional in VTT files, following the spec #48

Closed sachac closed 2 years ago

sachac commented 2 years ago
rndusr commented 2 years ago

Thanks, again!

I would like to give you push access, but I have no idea how this works. I've invited you as a collaborator, maybe that's it?

sachac commented 2 years ago

Yes, that looks like it worked. I shall try to use this power only for good. :)

On Fri., Nov. 5, 2021, 06:41 rndusr, @.***> wrote:

Thanks, again!

I would like to give you push access, but I have no idea how this works. I've invited you as a collaborator, maybe that's it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rndusr/subed/pull/48#issuecomment-961790008, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACD7ERUZIWBUVIQ6WG2BZDUKOYENANCNFSM5HMADIRA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

rndusr commented 2 years ago

Yes, that looks like it worked. I shall try to use this power only for good. :)

Ah, yes, I forgot to mentioned that: Don't make a mess! :)

But you seem to know what you're doing. Probably more so than me since I haven't written any elisp in forever.

Happy hacking!

sachac commented 2 years ago

Would it be okay with you if I submit it for inclusion in NonGNU ELPA and make whatever changes emacs-devel requests? That would make it much easier for people to install, encouraging more people to caption/sub media.

Sacha

On Fri, Nov 5, 2021 at 5:18 PM rndusr @.***> wrote:

Yes, that looks like it worked. I shall try to use this power only for good. :)

Ah, yes, I forgot to mentioned that: Don't make a mess! :)

But you seem to know what you're doing. Probably more so than me since I haven't written any elisp in forever.

Happy hacking!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rndusr/subed/pull/48#issuecomment-962227038, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACD7ER4IPYDI7RWWECVPL3UKRC35ANCNFSM5HMADIRA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

rndusr commented 2 years ago

Yes, please! Thank you!

I tried adding it to Melpa[1] but gave up eventually. Emacs doesn't like my hacks and Melpa doesn't like that Emacs doesn't like my hacks. And I didn't care enough.

You should be able to reproduce the offending errors with make test-compile.

[1] https://github.com/melpa/melpa/pull/6255

sachac commented 2 years ago

Oh yeah, that's useful, thanks for the link. After I get past captioning the upcoming EmacsConf, I can look into rewriting the common function stuff and other things, probably borrowing some ideas from the way Org or other packages handle buffer-specific behavior. I'll keep it in a branch.

On Sat., Nov. 6, 2021, 17:17 rndusr, @.***> wrote:

Yes, please! Thank you!

I tried adding it to Melpa[1] but gave up eventually. Emacs doesn't like my hacks and Melpa doesn't like that Emacs doesn't like my hacks. And I didn't care enough.

You should be able to reproduce the offending errors with make test-compile.

[1] https://github.com/melpa/melpa/pull/6255

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rndusr/subed/pull/48#issuecomment-962511140, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACD7EVL7GOB6UCNEK337Q3UKWLNVANCNFSM5HMADIRA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

sachac commented 2 years ago

Looks like someone already got it into NonGNU ELPA, yay! I'm still thinking about derived modes. It's probably a medium-sized change. Do you want me to keep it in a branch for your review or just go ahead and make the changes on master when it's ready?

rndusr commented 2 years ago

Looks like someone already got it into NonGNU ELPA, yay!

Yay indeed! It's so nice to see people caring and contributing. The Emacs community is the best!

Unfortunately, I lost interest in this project. I use subed maybe once every few months, and it already has more features than I need. I haven't touched any Elisp code in... forever. I don't know what derived modes are anymore.

Would you be interested in taking full control of this project? You are doing all the work anyway. I just nod from time to time, acting like I understand what's going on. I think subed would be in better hands.

Of course, you could still ping me and pick my brain any time.

sachac commented 2 years ago

Sure, I can take over as the maintainer. :) I'll update the docs later. Thanks for getting it started!

Sacha

rndusr commented 2 years ago

Great! But there's an issue. When I try to transfer the repo, it says "sachac/subed already exists".

From https://docs.github.com/en/repositories/creating-and-managing-repositories/transferring-a-repository:

"The target account must not have a repository with the same name, or a fork in the same network."

Can you delete or rename your fork?

sachac commented 2 years ago

Deleted my fork. After the transfer, I'll coordinate with NonGNU ELPA as well. =)

Sacha

On Sun, Dec 19, 2021 at 1:37 PM rndusr @.***> wrote:

Great! But there's an issue. When I try to transfer the repo, it says "sachac/subed already exists".

From https://docs.github.com/en/repositories/creating-and-managing-repositories/transferring-a-repository :

"The target account must not have a repository with the same name, or a fork in the same network."

Can you delete or rename your fork?

— Reply to this email directly, view it on GitHub https://github.com/rndusr/subed/pull/48#issuecomment-997440220, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACD7ESMT5Q2W5KUCLG6YCDURYQ6NANCNFSM5HMADIRA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

rndusr commented 2 years ago

It worked.

Thank you for giving subed a new life!