Define `subed-loop-seconds-before` and `subed-loop-seconds-after` in millisecond?

[whatacold]

As I was using the looping-over feature of subed heavily to practice English shadowing (as I described in /r/emacs), I noticed that there is an additional second by default added to before and after the loop, as specified by subed-loop-seconds-before and subed-loop-seconds-after.

Since video timestamps are usually in milliseconds, I think it's better to define them in milliseconds, as opposed to seconds.

But to be compatible, it may be tedious to achieve it if we decide to do so.

(At first, I setq both of them to 0. Last night, but I thought I'd better have an extra time of 200ms, then I (setq subed-loop-seconds-after 200) and the looping didn't stop. I didn't realize what was wrong until a few moments ago😂)

Also, I think maybe we could only provide one customizable variable like subed-loop-milliseconds-gap, as there isn't much difference between before and after regarding a loop.

What do you think?

[rndusr]

Since video timestamps are usually in milliseconds

I disagree. mpv displays seconds and srt specifies timestamps in seconds.

They also use fractions of seconds, but subed also lets you do this. You can set subed-loop-seconds-* to 0.2.

Having different config options just to get different unit prefixes sounds like a nightmare to maintain.

[whatacold]

You can set subed-loop-seconds-* to 0.2.

Ah, that also works, why I didn't think of using a fraction.😷