search

sachaos / todoist

Todoist CLI Client. I ❤️ Todoist and CLI.
MIT License
1.48k stars 104 forks source link

Uncomment and fix filter tests #241

Open psethwick opened 1 year ago

psethwick commented 1 year ago

Fixes:

  1. test code incorrectly setting up Items with label ids instead of names (test-only fix)
  2. Item.DateTime() now checks Item.Due.TimeZone and uses it
    • root cause: daylight savings time (which JST does not have)
    • (in order for the tests to pass I also set them in the same timezone the tests expect)
  3. filter parser was getting stuck on times in pm because .Scan() tried to parse it as a float

ref #210

psethwick commented 1 year ago

This PR was really just preparing for what I wanted to do, which was more fully implement the filter language.

I have done the further work, you can see it here: https://github.com/psethwick/todoist/pull/1/files

How should I proceed, should I put those in this PR? I know it is a lot of change :-/

Happy to rework things here and there, too!