sachaos / viddy

👀 A modern watch command. Time machine and pager etc.
MIT License
4.74k stars 94 forks source link

Suspend, Diff and Bell status circles for colorblind people #48

Open Nani-o opened 2 years ago

Nani-o commented 2 years ago

Hi, just discovered your app and this is an awesome replacement to the watch command.

Would it be possible for you to make the green/red status circle next to the Suspend, Diff and Bell color configurable ? Or even better to make the circle filled when active and unfilled when inactive ?

Red and Green on a such thin circle is really difficult to distinguish for a colorblind person like me.

abhaysp95 commented 2 years ago

@Nani-o I think adding accessibility option in the config file of viddy would be good. If the option is set to true, it'll change then upon setting Setting, Diff and Bell, it'll change the empty circle to fill circle in addition to changing color and will also set the background color for text and related circle for the set option. It would be helpful if you can tell what color would you like to set for foreground and background when the option is on.

Nani-o commented 2 years ago

I'm not sure there is one color set that fit them all. My colorblindness is deuteranotopia, which mostly resolves in not being able to distinguish green and red nuances. So generally I like more the blue/red scheme (blue replacing the green).

Typically in games, the accessibility setting for colorblindness propose multiple mode for each variant of the "disease". It sounds like a lot of work and might be impractical to set in a config file, you certainly better off letting people choose the color of the circle for each state. I let you judge on that.

phanirithvij commented 2 months ago

@Nani-o does the latest rust version (without colored circles next to suspend etc) look right?

If you think so, you may close this issue as completed.