search

sachatrauwaen / OpenContent

Structured Content editing for DNN (Dotnetnuke)
46 stars 25 forks source link

publishstartdate and publishenddate ignore time #166

Closed Timo-Breumelhof closed 3 years ago

Timo-Breumelhof commented 3 years ago

When using this in the options:

"publishstartdate": {
  "type": "date",
  "picker": {
    "format": "DD-MM-YYYY HH:mm",
    "minDate": "2000-01-01",
    "maxDate": "2099-12-31"
  }
},
"publishenddate": {
  "type": "date",
  "picker": {
    "format": "DD-MM-YYYY HH:mm",
    "minDate": "2000-01-01",
    "maxDate": "2099-12-31"
  }
},

The time is ignored by OC and only the date is considered. This seems to be due to these lines:

https://github.com/sachatrauwaen/OpenContent/blob/d76d2b2e05f4bdb7e26f4b5ddd8316ec2c483d62/OpenContent/Components/Handlebars/HandlebarsEngine.cs#L427

https://github.com/sachatrauwaen/OpenContent/blob/d76d2b2e05f4bdb7e26f4b5ddd8316ec2c483d62/OpenContent/Components/Handlebars/HandlebarsEngine.cs#L438

IMO these comparisons should be between publishenddate and DateTime.Now if the time is not 00:00

Timo-Breumelhof commented 3 years ago

Fixed in 04.07.00