removed logger impl deps from compile/runtime cp

sachin-handiekar / jInstagram

A Java library for the Instagram API.

MIT License

385 stars 167 forks source link

removed logger impl deps from compile/runtime cp #187

Closed abargnesi closed 7 years ago

abargnesi commented 8 years ago

Motivation

Including logger implementations within a library can cause logging issues when including in an application. Usually an application will have specific logging needs and will provide the slf4j log implementation.

Solution

This change removes log4j dependencies from the compile/runtime classpath of jInstagram. Only the slf4j API is included.

Additionally logback-classic (slf4j logger impl) is added on the test classpath for test log debugging.

coveralls commented 8 years ago

Coverage decreased (-9.9%) to 56.928% when pulling ebf935d1d8c70cd7c76cf9322007768d7bc3d403 on abargnesi:clean-up-logger-deps into 9c89b9f651471cab8b138c45acf99de2d13d009d on sachin-handiekar:master.

abargnesi commented 7 years ago

Any thoughts @sachin-handiekar?