Make HTTP header keys case insensitive, make header parsing null safe

sachin-handiekar / jInstagram

A Java library for the Instagram API.

MIT License

385 stars 167 forks source link

Make HTTP header keys case insensitive, make header parsing null safe #206

Closed xberger closed 7 years ago

xberger commented 7 years ago

HTTP headers are case-insensitive (RFC 7230 / RFC 7540). Thus the headers are stored using a java.util.TreeMap with a String.CASE_INSENSITIVE_ORDER comparator.

This is a real life issue under Google App Engine, described here: https://github.com/sachin-handiekar/jInstagram/issues/79

coveralls commented 7 years ago

Coverage decreased (-5.9%) to 61.069% when pulling 039f8c2f70628572803f578560fab4ae14b134a7 on xberger:master into d23918542cf016c3f3394fb3fe6759d2b2c9f009 on sachin-handiekar:master.