search

sachinchoolur / lightGallery

A customizable, modular, responsive, lightbox gallery plugin.
https://www.lightgalleryjs.com/
Other
6.52k stars 1.28k forks source link

Claiming "no dependencies" is false #1191

Open mrjones2014 opened 3 years ago

mrjones2014 commented 3 years ago

Description

The README.md claims "no dependencies" but that is false.

Steps to reproduce

Look at the package.json

Expected result

There should be no dependencies.

Actual result

There are dependencies.

Additional context

Even if you ignore the things that really should be in devDependencies (npm, i, and @types/picturefill), video.js is still a real dependency.

sachinchoolur commented 3 years ago

These are optional dependencies. lightGallery will work without these dependencies. For example, videoJs is required only if you want to use videojs with lightGallery. I think this can be moved to optionaldependencies field

stof commented 2 years ago

As video.js is meant to be provided by the project rather than being required by lightgallery, I think peerDependencies would even be better (with peerDependenciesMeta marking it optional).

And npm and i should probably be removed entirely (I suspect it was a result of calling npm i npm i something --save by mistake)